Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for pre-1.10 #129

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Drop support for pre-1.10 #129

wants to merge 23 commits into from

Conversation

Red-Portal
Copy link
Member

@Red-Portal Red-Portal commented Oct 8, 2024

  • Change CI to test only on 1.10 and 1
  • Remove all uses to SimpleUnPack in favor of the (; ret1, ret2) = func() syntax.
  • Separate Enzyme into its own CI workflow.
  • Wait until the upstream (Julia) bugfixes get shipped.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Benchmark suite Current: f206f7b Previous: 09b81ee Ratio
normal/RepGradELBO + STL/meanfield/Zygote 15078319781 ns 15489443300 ns 0.97
normal/RepGradELBO + STL/meanfield/ForwardDiff 3625670767 ns 3505509464 ns 1.03
normal/RepGradELBO + STL/meanfield/ReverseDiff 3395701183 ns 3247853596 ns 1.05
normal/RepGradELBO + STL/fullrank/Zygote 15116863602 ns 15235026725 ns 0.99
normal/RepGradELBO + STL/fullrank/ForwardDiff 3944226179 ns 3831033989 ns 1.03
normal/RepGradELBO + STL/fullrank/ReverseDiff 6139722083 ns 6017306487 ns 1.02
normal/RepGradELBO/meanfield/Zygote 7253389710 ns 7380650072 ns 0.98
normal/RepGradELBO/meanfield/ForwardDiff 2632993115 ns 2475600557 ns 1.06
normal/RepGradELBO/meanfield/ReverseDiff 1576403543 ns 1548041038.5 ns 1.02
normal/RepGradELBO/fullrank/Zygote 7306039560 ns 7453788446 ns 0.98
normal/RepGradELBO/fullrank/ForwardDiff 2840947231 ns 2659803352 ns 1.07
normal/RepGradELBO/fullrank/ReverseDiff 2739226599 ns 2730304200 ns 1.00
normal + bijector/RepGradELBO + STL/meanfield/Zygote 23653390745 ns 23442368232 ns 1.01
normal + bijector/RepGradELBO + STL/meanfield/ForwardDiff 9866085988 ns 8789034886 ns 1.12
normal + bijector/RepGradELBO + STL/meanfield/ReverseDiff 4849345847 ns 4756885202 ns 1.02
normal + bijector/RepGradELBO + STL/fullrank/Zygote 23305322822 ns 23276321282 ns 1.00
normal + bijector/RepGradELBO + STL/fullrank/ForwardDiff 9938549134 ns 9439366628 ns 1.05
normal + bijector/RepGradELBO + STL/fullrank/ReverseDiff 8146814462 ns 7973877978 ns 1.02
normal + bijector/RepGradELBO/meanfield/Zygote 14724622532 ns 14740241990 ns 1.00
normal + bijector/RepGradELBO/meanfield/ForwardDiff 8308024002 ns 8107084371 ns 1.02
normal + bijector/RepGradELBO/meanfield/ReverseDiff 2841611924 ns 2752578732 ns 1.03
normal + bijector/RepGradELBO/fullrank/Zygote 14769912290 ns 14777967633 ns 1.00
normal + bijector/RepGradELBO/fullrank/ForwardDiff 8231288155 ns 7966018701 ns 1.03
normal + bijector/RepGradELBO/fullrank/ReverseDiff 4313583587 ns 4273933874 ns 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@Red-Portal Red-Portal added this to the v0.3.0 milestone Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.54%. Comparing base (0383ce6) to head (f206f7b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files          12       12           
  Lines         372      372           
=======================================
  Hits          348      348           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Red-Portal
Copy link
Member Author

There was an upstream bug that got caught. For this to be fixed, we'll need to wait until Julia 1.11.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants