Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kwarg nadapt #332

Merged
merged 5 commits into from
Jul 26, 2023
Merged

kwarg nadapt #332

merged 5 commits into from
Jul 26, 2023

Conversation

JaimeRZP
Copy link
Member

The current constructors take n_adapts as well as other initialization options as a field to follow the Turing API as close as possible.
However, ideally the intialization should be independent of the sampler.
This PR is a small step towards that goal.
In the future we would like to give other initialization options the same treatment.

test/constructors.jl Outdated Show resolved Hide resolved
test/constructors.jl Outdated Show resolved Hide resolved
@JaimeRZP JaimeRZP requested a review from yebai July 25, 2023 15:11
@yebai
Copy link
Member

yebai commented Jul 26, 2023

Thanks, @JaimeRZP!

@yebai yebai merged commit da87eb4 into master Jul 26, 2023
16 checks passed
@delete-merged-branch delete-merged-branch bot deleted the nadapts branch July 26, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants