-
Notifications
You must be signed in to change notification settings - Fork 44
Moved all experimental code including tests into research folder. #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@yebai If we want to do this setup, we will need to carefully |
Just to add my preference here: I feel this setup makes experimenting a bit hard as we need to do those extra management. In fact, if we want to separate the code like this, we may well just keep the research code in a separate repo. The main benefit of having it here is that we can change AHMC itself more in an invasive manner with an implementation that could be easily cherry picked into the main branch. |
The idea is to use a standalone Julia environment (project) fro each experimental project. These environments manage their own dependencies like the |
FYI: JuliaLang/julia#47695 will make it possible to have conditional dependency soon, so keeping everything on the |
* feat: relativistic HMC * chore: move codes to experimental folder * chore: commit unsaved change * chore: warp experimental codes into a seperate module * chore: remove new the module * chore: create experimental tests and set up CI * Moved all experimental code including tests into research folder. (#304) * Moved all experimental code into research folder. * Minor changes in deps. * Improve tests for experimental code. * Change CI name. * Fix path for research includes. * More fixes to includes * Minor fixes. * Update research/src/relativistic_hmc.jl * Apply suggestions from code review * Create README.md * Update research/src/relativistic_hmc.jl * Update relativistic_hmc.jl Co-authored-by: Kai Xu <contact@xuk.ai> Co-authored-by: Kai Xu <xuk@amazon.com> Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>
No description provided.