Skip to content

Moved all experimental code including tests into research folder. #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Dec 7, 2022

Conversation

yebai
Copy link
Member

@yebai yebai commented Nov 30, 2022

No description provided.

@yebai yebai requested a review from xukai92 November 30, 2022 18:07
@xukai92
Copy link
Member

xukai92 commented Nov 30, 2022

@yebai If we want to do this setup, we will need to carefully using internal names from AHMC. The CI is broken because of this; see more at #304 (comment).

@xukai92
Copy link
Member

xukai92 commented Dec 2, 2022

Just to add my preference here: I feel this setup makes experimenting a bit hard as we need to do those extra management. In fact, if we want to separate the code like this, we may well just keep the research code in a separate repo. The main benefit of having it here is that we can change AHMC itself more in an invasive manner with an implementation that could be easily cherry picked into the main branch.

@yebai
Copy link
Member Author

yebai commented Dec 7, 2022

Just to add my preference here: I feel this setup makes experimenting a bit hard as we need to do those extra management. In fact, if we want to separate the code like this, we may well just keep the research code in a separate repo. The main benefit of having it here is that we can change AHMC itself more in an invasive manner with an implementation that could be easily cherry picked into the main branch.

The idea is to use a standalone Julia environment (project) fro each experimental project. These environments manage their own dependencies like the tests folder. In addition, we can work with one branch master for research code too, since the algorithms in the research folder is not loaded by default: users have to explicitly instantiate them.

@yebai
Copy link
Member Author

yebai commented Dec 7, 2022

FYI: JuliaLang/julia#47695 will make it possible to have conditional dependency soon, so keeping everything on the master branch will be possible without separate environments for the research folder -- it also means we can load the research folder by default. So having a clear separation is now only for clarity rather than avoiding unnecessary dependencies needed by research code in the stable releases.

@yebai yebai merged commit 1923fca into kx/relativistic Dec 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the hg/rel-hmc branch December 7, 2022 16:15
yebai added a commit that referenced this pull request Dec 7, 2022
* feat: relativistic HMC

* chore: move codes to experimental folder

* chore: commit unsaved change

* chore: warp experimental codes into a seperate module

* chore: remove new the module

* chore: create experimental tests and set up CI

* Moved all experimental code including tests into research folder.  (#304)

* Moved all experimental code into research folder.

* Minor changes in deps.

* Improve tests for experimental code.

* Change CI name.

* Fix path for research includes.

* More fixes to includes

* Minor fixes.

* Update research/src/relativistic_hmc.jl

* Apply suggestions from code review

* Create README.md

* Update research/src/relativistic_hmc.jl

* Update relativistic_hmc.jl

Co-authored-by: Kai Xu <contact@xuk.ai>
Co-authored-by: Kai Xu <xuk@amazon.com>
Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants