Defaultn_adapts and discard_initial to zero
#124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #124 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 8 8
Lines 305 305
=======================================
Hits 297 297
Misses 8 8
☔ View full report in Codecov by Sentry. |
devmotion
reviewed
Jul 29, 2023
| @@ -100,6 +100,7 @@ function mcmcsample( | |||
| progress=PROGRESS[], | |||
| progressname="Sampling", | |||
| callback=nothing, | |||
| n_adapts=0, | |||
There was a problem hiding this comment.
n_adapts is not a general thing (in contrast to discard_initial), so my feeling is this should not be specified in AbstractMCMC but downstream packages where it is relevant.
| @@ -395,6 +399,8 @@ function mcmcsample( | |||
| ::MCMCDistributed, | |||
| N::Integer, | |||
| nchains::Integer; | |||
| n_adapts=0, | |||
| discard_initial=0, | |||
There was a problem hiding this comment.
This should not be needed - the keyword arguments are forwarded to the single-chain version and there a default of 0 is already specified.
There was a problem hiding this comment.
The same is true for the other ensemble algorithms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some downstream MCMC sampling package, e.g., AHMC, now assumes we always pass
n_adaptsto theAbstractMCMC.stepfunction. It might be sensible to default these arguments to 0 when users didn't specify them to avoid missingn_adaptserrors.