-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defaultn_adapts
and discard_initial
to zero
#124
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #124 +/- ##
=======================================
Coverage 97.37% 97.37%
=======================================
Files 8 8
Lines 305 305
=======================================
Hits 297 297
Misses 8 8
☔ View full report in Codecov by Sentry. |
@@ -100,6 +100,7 @@ function mcmcsample( | |||
progress=PROGRESS[], | |||
progressname="Sampling", | |||
callback=nothing, | |||
n_adapts=0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
n_adapts
is not a general thing (in contrast to discard_initial
), so my feeling is this should not be specified in AbstractMCMC but downstream packages where it is relevant.
@@ -395,6 +399,8 @@ function mcmcsample( | |||
::MCMCDistributed, | |||
N::Integer, | |||
nchains::Integer; | |||
n_adapts=0, | |||
discard_initial=0, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be needed - the keyword arguments are forwarded to the single-chain version and there a default of 0 is already specified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same is true for the other ensemble algorithms.
Some downstream MCMC sampling package, e.g., AHMC, now assumes we always pass
n_adapts
to theAbstractMCMC.step
function. It might be sensible to default these arguments to 0 when users didn't specify them to avoid missingn_adapts
errors.