Add DPPL models #23
Merged
Add DPPL models #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penelopeysm
force-pushed
the
py/dppl-models
branch
2 times, most recently
from
0db8abf to
39487cc
Compare
This was referenced May 22, 2025
penelopeysm
force-pushed
the
py/dppl-models
branch
from
408c6d9 to
c1b0cee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This PR is basically complete in terms of adding the models. However, unfortunately, this is blocked by DynamicPPL 0.37 as there are spurious errors in the AD accuracy testing. These were fixed in TuringLang/DynamicPPL.jl#964 but have yet to be released.
This PR adds the models benchmarked in https://arxiv.org/pdf/2002.02702.
Some code was not very reproducible so had to be updated.
Closes #21