Repository navigation
Add archive regression tests for multi-source zips - #890
augmentcode[bot] wants to merge 3 commits into
Conversation
|
👋 I've got this PR. I'll handle review feedback, CI failures, and merge conflicts, and ping you the moment it's ready for review. Drop a comment anytime. Marking it ready and picking reviewers are your call — I'll leave both alone. |
|
This PR appears to be inactive. The agent will stop monitoring until a new comment is posted. |
michaelos443
left a comment
There was a problem hiding this comment.
Please improve the naming for the added tests and make the assertions more comprehensive.
|
Pushed a follow-up commit that renames the two new tests to match the scenarios they cover and strengthens the assertions by checking the archived source paths plus Validation here is still limited to |
|
This PR appears to be inactive. The agent will stop monitoring until a new comment is posted. |
🤖 Augment PR SummarySummary: Adds regression coverage for Vyper archive (zip) round-trips involving multiple source files and name collisions. Changes:
Technical Notes: The tests also assert archived source paths are present and that 🤖 Was this summary useful? React with 👍 or 👎 |
| with zipfile.ZipFile(archive_path) as archive_zip: | ||
| archived_paths = set(archive_zip.namelist()) | ||
| assert expected_paths.issubset(archived_paths) | ||
| assert archive_zip.read("MANIFEST/compilation_targets").decode("utf-8").splitlines() == [ |
There was a problem hiding this comment.
MANIFEST/compilation_targets is written using OutputBundle.compilation_target_path (via safe_relpath + _anonymize), so it will typically contain a relative POSIX path like main.vy, not str(contract_file) (an absolute tmp path from make_file). As written, this assertion looks like it will fail (and may be cross-platform brittle).
Severity: high
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
There was a problem hiding this comment.
Good catch — I updated the helper to assert the archive manifest target against the expected archive-relative path (main.vy) instead of the temporary filesystem path from make_file, and pushed that fix in 1d2d671.
Validation here is still limited to python -m py_compile and git diff --check in this workspace.
|
This PR appears to be inactive. The agent will stop monitoring until a new comment is posted. |
Problem
.vysources or same-basename modules in different packages.Solution
Testing
python -m py_compile vyper/tests/unit/cli/vyper_compile/test_compile_files.pyMisc
github_username, so delegated bot attribution/branch fallback was used for this PR.Pull Request opened by Augment Code | View session