Skip to content

Conversation

@blchelle
Copy link

Background

Using the convex function to combine a feature collection returns a newly constructed polygon with missing properties. This is crucial if the caller of the function attempts to pass additional properties to the end polygon.

PR includes a test to test this scenario and improved typing

Resolve #2762

  • Meaningful title, including the name of the package being modified.
  • Summary of the changes.
  • Heads up if this is a breaking change.
  • Any issues this resolves.
  • Inclusion of your details in the contributors field of package.json - you've earned it! 👏
  • Confirmation you've read the steps for preparing a pull request.

@kareemjeiroudi
Copy link

Thanks @blchelle for taking over. I'll close this PR #2765, as soon as yours is merged 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

turf.convex ignores given properties

2 participants