Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 2342 - Handle when start and end are the same point in greatCircle #2343

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Issue 2342 - Handle when start and end are the same point in greatCircle #2343

merged 6 commits into from
Oct 15, 2024

Conversation

rowanwins
Copy link
Member

@rowanwins rowanwins commented Oct 6, 2022 •
edited
Loading

This prevents an array of NaN's coming back when start and end points are the same.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Have read How To Contribute.
  • Run npm test at the sub modules where changes have occurred.
  • Run npm run lint to ensure code style at the turf module level.

Resolves #2342

@rowanwins rowanwins requested a review from twelch October 6, 2022 05:38
mfedderly
mfedderly reviewed Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@mfedderly mfedderly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like something we should merge. Do you have time to fix up the merge conflicts? I think that the CHANGELOG.md change can just be dropped because we are calculating them from the PR titles now.

@smallsaucepan smallsaucepan self-assigned this Oct 15, 2024
@smallsaucepan
Copy link
Member

Will take a look and get ready to merge.

@smallsaucepan
Copy link
Member

Ready to merge if you're still happy @mfedderly?

@mfedderly mfedderly merged commit 3b5f94a into master Oct 15, 2024
3 checks passed
@mfedderly mfedderly deleted the issue-2342 branch October 15, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfedderly mfedderly mfedderly left review comments

@smallsaucepan smallsaucepan smallsaucepan approved these changes

@twelch twelch Awaiting requested review from twelch

Assignees

@smallsaucepan smallsaucepan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

greatCircle returns array of NaN if start and end is the same
3 participants
@rowanwins @smallsaucepan @mfedderly