Skip to content

Completely rework monitor handling of Object and Arrays #1113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GarboMuffin merged 3 commits into from
Nov 21, 2025
Merged

Completely rework monitor handling of Object and Arrays #1113

GarboMuffin merged 3 commits into from
Nov 21, 2025

Conversation

@CubesterYT
Copy link
Member

@CubesterYT CubesterYT commented Nov 16, 2025

This was ported over from NitroBolt

It handles variable monitors and lists better, and doesn't do that weird thing to arrays.

image

GarboMuffin
GarboMuffin reviewed Nov 18, 2025
View reviewed changes
@GarboMuffin GarboMuffin merged commit b6367bd into TurboWarp:develop Nov 21, 2025
1 check passed
GarboMuffin added a commit that referenced this pull request Dec 5, 2025
@GarboMuffin
Rewrite #1113
5cb812b 
- It did an unnecessary extra list copy by using .map. Might've caused extra re-renders though not sure.
- Did not stringify null
- Had a lot of lint errors though we don't enforce that here
@GarboMuffin
Copy link
Member

GarboMuffin commented Dec 5, 2025

This broke saving in https://turbowarp.org/10128407 btw

image

@SharkPool-SP SharkPool-SP mentioned this pull request Dec 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GarboMuffin GarboMuffin Awaiting requested review from GarboMuffin

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CubesterYT @GarboMuffin