-
Notifications
You must be signed in to change notification settings - Fork 302
feat: add securelocalstorage (Local Storage V2) #2258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add securelocalstorage (Local Storage V2) #2258
Conversation
|
@Brackets-Coder could this be reviewed? |
|
i'm not opposed to making the existing local storage extension store the namespace in extensionStorage so that people don't need to run that block all that time, and you can make it generate a UUID on first launch if you want, that's fine but calling this scheme "secure" is definitely misleading. you shouldn't be doing that |
Resolved |
|
is there a reason you can't add the autogenerated id + persistence to the original extension? |
|
I am not approving LLM-generated code. |
I have removed the LLM-generated code |
PPPDUD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ampelectrecuted Thank you for removing the LLM-generated code.
|
!format |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
GarboMuffin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a reason you can't add the autogenerated id + persistence to the original extension?
That's actually a pretty good idea, but it might cause compatibility issues the way I'm seeing it. |
|
it shouldn't cause compatibility issues unless the project is showing the warnings about running blocks in the wrong order, in which case it is already broken and we're not breaking it any more |
Basically like the current Local Storage extension but less hackable.