Skip to content

Conversation

@ampelectrecuted
Copy link

@ampelectrecuted ampelectrecuted commented Sep 28, 2025

Basically like the current Local Storage extension but less hackable.

@ampelectrecuted ampelectrecuted marked this pull request as draft September 28, 2025 21:44
@github-actions github-actions bot added the pr: new extension Pull requests that add a new extension label Sep 28, 2025
@ampelectrecuted
Copy link
Author

@Brackets-Coder could this be reviewed?

@GarboMuffin
Copy link
Member

GarboMuffin commented Sep 28, 2025

i'm not opposed to making the existing local storage extension store the namespace in extensionStorage so that people don't need to run that block all that time, and you can make it generate a UUID on first launch if you want, that's fine

but calling this scheme "secure" is definitely misleading. you shouldn't be doing that

@ampelectrecuted
Copy link
Author

but calling this scheme "secure" is definitely misleading. you shouldn't be doing that

Resolved

@GarboMuffin
Copy link
Member

is there a reason you can't add the autogenerated id + persistence to the original extension?

@PPPDUD
Copy link
Member

PPPDUD commented Sep 29, 2025

I am not approving LLM-generated code.

@ampelectrecuted
Copy link
Author

I am not approving LLM-generated code.

I have removed the LLM-generated code

Copy link
Member

@PPPDUD PPPDUD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ampelectrecuted Thank you for removing the LLM-generated code.

@ampelectrecuted
Copy link
Author

!format

@Brackets-Coder

This comment was marked as off-topic.

@PPPDUD

This comment was marked as off-topic.

Copy link
Member

@GarboMuffin GarboMuffin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason you can't add the autogenerated id + persistence to the original extension?

@ampelectrecuted
Copy link
Author

is there a reason you can't add the autogenerated id + persistence to the original extension?

That's actually a pretty good idea, but it might cause compatibility issues the way I'm seeing it.
Might wait until others review the extension for some feedback before possibly closing it.

@GarboMuffin
Copy link
Member

it shouldn't cause compatibility issues unless the project is showing the warnings about running blocks in the wrong order, in which case it is already broken and we're not breaking it any more

@GarboMuffin
Copy link
Member

#2270

@GarboMuffin GarboMuffin closed this Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: new extension Pull requests that add a new extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants