Skip to content

New extension: File read and download #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2022
Merged

New extension: File read and download #19

merged 2 commits into from
Nov 6, 2022

Conversation

GarboMuffin
Copy link
Member

@GarboMuffin GarboMuffin commented Nov 6, 2022

image

which opens a modal that looks like this (design temporary, known to be ugly) because we can't reliably open an input dialog without user interaction

image

@GarboMuffin GarboMuffin changed the title File read and download extension New extension: File read and download Nov 6, 2022
@GarboMuffin GarboMuffin linked an issue Nov 6, 2022 that may be closed by this pull request
@FilipeCollura
Copy link

Is the modal customizable? And if it cannot, can it be hidden? Thanks! :)

@Mickmick21

This comment was marked as off-topic.

@FilipeCollura
Copy link

That is not an available option. I can only choose to either show the modal or open the selector immediately.

@GarboMuffin
Copy link
Member Author

I'll restate what I said in #28 (yes that's a bit buried and hard to find)

I'm hesitant to add a way to remove the prompt entirely because:

  • Browsers don't always let us open a file dialog, and they don't tell us when they refuse to, so the script would get stuck forever if there wasn't a way for people to manually open the dialog
  • Browsers don't reliably tell us when someone presses cancel on the dialog (only Firefox implements oncancel), so people need way to cancel the file dialog manually, otherwise the script gets stuck forever
  • Drag+drop is a very common way for people to select files. Operating system files prompts do not accommodate this.

Regardless, I did end up adding this as a hidden mode:

image

(the second text input there is completely empty, not even a space)

for the reasons mentioned previously, I don't recommend using this mode, so it hasn't been added to the dropdown at this time.

@GarboMuffin
Copy link
Member Author

If you want additional customization, please describe that more specifically

@FilipeCollura
Copy link

Thanks for this info. I wanted to remove it completely because it really didn't fit with my projects theme. If there's a way to customize the popup so that it can fit my theme, it would be great! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

save & open file extension
3 participants