Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIDI Extension #1725

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

MIDI Extension #1725

wants to merge 9 commits into from

Conversation

Brackets-Coder
Copy link

@Brackets-Coder Brackets-Coder commented Oct 15, 2024

I previously had a PR for this extension, but due to technical difficulties and organization purposes I've closed it and made a new PR using a different branch (I'm semi-new to Github, so I didn't initially fork the repo correctly).

This extension manages MIDI input. While support for MIDI output is possible in the future, I'm not planning on it at the moment. Currently, only MIDI note input is supported. Other MIDI input events return a console log. This means things like pitch bend, damper pedals, etc. will not work.

Note that MIDI compatibility varies depending on which browser you're using. If the browser doesn't have MIDI API support, it will return an error, show an alert, and the extension won't load.

I've made a sample project, but I won't add it until this gets merged because it uses localhost instead of extensions.turbowarp.org.

353662493-3f9327ac-dd48-4dad-8b59-e35de05e76e6

@GarboMuffin GarboMuffin added the pr: new extension Pull requests that add a new extension label Oct 15, 2024
@CubesterYT CubesterYT self-assigned this Oct 15, 2024
@CubesterYT
Copy link
Collaborator

I'll need to remember to handle this PR

Brackets-Coder and others added 3 commits October 16, 2024 15:27
I've ran prettier like a few dozen times with the same version and settings as the repo. If this fails I have no idea why
@Brackets-Coder
Copy link
Author

Brackets-Coder commented Oct 17, 2024

Something to note: I haven't tested the latest commit, but it basically just condenses some blocks into single blocks with inputs, and it passed all checks, so I'm assuming it works. Code looks perfect, but I can't test it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: new extension Pull requests that add a new extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants