This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
MediaDownloadService: Run Glide clear on main thread #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #56 Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
msfjarvis
force-pushed
the
msf/fix-redownload-crash
branch
from
9ebc68c
to
f4680d1
Compare
msfjarvis
changed the title
|
Test version of Dank has been automatically built from this pull request. |
Tunous
approved these changes
Aug 21, 2019
mvietri
pushed a commit
to mvietri/Dawn
that referenced
this pull request
Aug 24, 2019
Fixes Tunous#56 Signed-off-by: Harsh Shandilya <msfjarvis@gmail.com>
|
Unfortunately it looks like this fix is not working properly in all cases. Bugsnag is reporting crashes (#77) that directly point at this change. Do you have other ideas for a fix? |
I'll look into it a bit more |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56