This repository has been archived by the owner on Jun 9, 2023. It is now read-only.
Fix Gfycat integration #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfjarvis
added
bug
Tunous
approved these changes
Nov 3, 2021
|
@Tunous maybe that would be worth making a new release so this fix reaches f-droid? |
|
Sure, I'll prepare play store and f-droid releases this weekend. |
|
@Tunous actually, redgifs integration is still broken :( |
It's a bit iffy, the services (gfycat and redgifs) like to both diverge and redirect to each other which makes this fairly hard to do. I had a WIP refactor of all of this code somewhere which fixes some of these problems, I'll try to find and clean it up sometime next week. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gfycat changed the API response yet again 🤷
The new JSON key is taken from the example in their wiki.