Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Fix Gfycat extractor #363

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Fix Gfycat extractor #363

merged 1 commit into from
Jan 22, 2021

Conversation

msfjarvis
Copy link
Collaborator

The GfyCat API no longer returns WebM videos and instead replaced them with MP4 for all qualities. The mobileUrl field contains a 480p video and the mp4Url field contains either 720p or 1080p depending on the source quality, which feels like a good approximation

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@AbsurdlySuspicious
Copy link
Collaborator

feels like a good approximation

Not like we have any other choice, I presume :D
There's no any Dash/HLS stream link in response, by any chance?

@msfjarvis
Copy link
Collaborator Author

feels like a good approximation

Not like we have any other choice, I presume :D
There's no any Dash/HLS stream link in response, by any chance?

Nope :(

@Tunous Tunous added this to the 0.12.1 milestone Jan 22, 2021
@Tunous Tunous added the bug Something isn't working label Jan 22, 2021
@msfjarvis msfjarvis merged commit 2c68361 into Tunous:master Jan 22, 2021
@msfjarvis msfjarvis deleted the fix-gfycat branch January 22, 2021 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants