Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Redgifs resolver and url parser #219

Merged
merged 6 commits into from
Jun 8, 2020
Merged

Redgifs resolver and url parser #219

merged 6 commits into from
Jun 8, 2020

Conversation

AbsurdlySuspicious
Copy link
Collaborator

No description provided.

@AbsurdlySuspicious AbsurdlySuspicious mentioned this pull request Jun 8, 2020
Closed
Tunous
Tunous suggested changes Jun 8, 2020
View reviewed changes
Copy link
Owner

@Tunous Tunous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only change I would like to request is to change the naming of new methods from snake_case to camelCase as that’s what is used everywhere.

@AbsurdlySuspicious
Copy link
Collaborator Author

AbsurdlySuspicious commented Jun 8, 2020 •
edited
Loading

+ fix for links with extension

@Tunous Tunous added this to the 0.9.2 milestone Jun 8, 2020
@Tunous Tunous merged commit d7d6541 into Tunous:master Jun 8, 2020
@Tunous Tunous added the feature New feature label Jun 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tunous Tunous Tunous approved these changes

Assignees
No one assigned
Labels
feature New feature
Projects
None yet
Milestone
0.9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@AbsurdlySuspicious @Tunous