Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Video player's play button animation doesn't work in reverse #53

Closed
Tunous opened this issue Aug 19, 2019 · 0 comments · Fixed by #58
Closed

Video player's play button animation doesn't work in reverse #53

Tunous opened this issue Aug 19, 2019 · 0 comments · Fixed by #58
Labels
bug Something isn't working
Milestone
0.8.0

Comments

@Tunous
Copy link
Owner

Tunous commented Aug 19, 2019

Describe the bug
Play/pause icon in the video player doesn't animate back from the pause icon to play icon.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any video
  2. Click on pause button

Expected behavior
Pause icon animates back to play icon.

Additional context
The issue is caused by the use of reverse method through reflection in ReversibleAnimatedVectorDrawable which is not available since API 24.
@Tunous Tunous added the bug Something isn't working label Aug 19, 2019
@Tunous Tunous added this to the 0.8.0 milestone Aug 19, 2019
Tunous added a commit that referenced this issue Aug 21, 2019
@Tunous
Fix animation of play/pause button
d119baa 
Closes #53
@Tunous Tunous mentioned this issue Aug 21, 2019
Merged
Tunous added a commit that referenced this issue Aug 22, 2019
@Tunous
Fix animation of play/pause button (#58)
737e208 
Closes #53
mvietri pushed a commit to mvietri/Dawn that referenced this issue Aug 24, 2019
@Tunous
Fix animation of play/pause button (Tunous#58)
03ef696 
Closes Tunous#53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

Fix animation of play/pause button Tunous/Dawn
1 participant
@Tunous