Trying to open page in external browser might result in crash

[Tunous]

Description

Precondition: A user has no installed browser

When attempting to open page in external browser Dawn crashes.

To Reproduce
Steps to reproduce the behavior:

1. Go to any link which will open in internal browser
2. Click on more options top bar item
3. Click on 'Open in browser' item

Expected behavior
Most likely an error message telling the user that no browser was found should be displayed.

Hints for fixing

The issue described here is caused by the following line:

Dawn/app/src/main/java/me/saket/dank/ui/webview/WebViewActivity.java

Line 117 in 77a6679

startActivity(Intents.createForOpeningUrl(webView.getUrl()));

In this case ActivityNotFoundException exception is thrown which crashes the app. The issue can occur everywhere where intent from Intents.createForOpeningUrl is passed to Context.startActivity. We should instead check whether the created intent can be opened or handle the exception and inform the user about the problem.

[Tunous]

Also can happen here:

Dawn/app/src/main/java/me/saket/dank/ui/webview/ChromeCustomTabsForwardingActivity.java

Line 43 in 77a6679

customTabsIntent.launchUrl(this, Uri.parse(url));

[SubhrajyotiSen]

Has this been resolved? If not, I can pick it up

[Tunous]

@SubhrajyotiSen It has not been fixed by anyone yet. Feel free to give it a try.