App info localization #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tuni
reviewed
Dec 9, 2020
appstoreconnect/api.py
Outdated
Comment on lines
601
to
606
| def modify_app_info(self, app_information: AppInfo, args): | ||
| """ | ||
| :reference: https://developer.apple.com/documentation/appstoreconnectapi/modify_an_app_info | ||
| :return: an iterator over AppInfo resources | ||
| """ | ||
| return self._modify_resource(app_information, args) |
Owner
There was a problem hiding this comment.
Il faudrait faire comme dans les autres fonctions de modify ( cf ce que j'ai fait sur modify_app_store_version ) et mettre des arguments ( ceux dont on a besoin pour le moment ).
Idéalement faudrait tous les mettre, mais ça n'est pas ce qui est fait dans l'API aujoud'hui. Peut etre que j'ouvrirai une discussion pour demander au dev originel si on devrait pas mettre tous les params possibles ou à défaut un dict générique supplémentaire pour pallier ce manquement.
Tuni
reviewed
Dec 9, 2020
appstoreconnect/api.py
Outdated
Comment on lines
618
to
624
| def modify_app_store_info_localization(self, AppInfoLocalization, attributes): | ||
| """ | ||
| :reference: https://developer.apple.com/documentation/appstoreconnectapi/modify_an_app_info_localization | ||
| :return: an iterator over AppInfoLocalization resources | ||
| """ | ||
| return self._modify_resource(AppInfoLocalization, attributes) | ||
|
|
Owner
There was a problem hiding this comment.
même remarque pour que pour l'autre fonction modify
Tuni
reviewed
Dec 9, 2020
appstoreconnect/api.py
Outdated
| """ | ||
| return self._get_resource(Build, build_id) | ||
|
|
||
| def read_app_category_info(self, app_category_id): |
Owner
There was a problem hiding this comment.
les fonctions sont regroupés en dessous de commentaires #
…ly ) added copyroth parameters form create and modify app store version functions
Change localisation of functions
…ion_localization parameters - add reference for list_app_store_version_localizations and list_app_store_info_localizations
Refactor app info localization
dmytrolutsyk
pushed a commit
to dmytrolutsyk/appstoreconnectapi
that referenced
this pull request
Jun 16, 2022
Generate token after 15 minutes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.