Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create all variables directly from connection and independent of dataframes #926

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Create all variables directly from connection and independent of dataframes #926

wants to merge 13 commits into from

Conversation

abelsiqueira
Copy link
Member

@abelsiqueira abelsiqueira commented Nov 9, 2024 •
edited
Loading

Blocked by #925

Create all variables with connection instead of dataframes variable.

With the lookup created in #925, this allow us to

Close #923

@abelsiqueira
Refactor variables to use TulipaVariable
e0c4337 
Create field lookup to allow changing the variables without
having to redefine the whole model creation

Related to #923
@abelsiqueira
[fixup] Refactor more variables
1edc06e
@abelsiqueira
[fixup] Missed a few things
ded14f2
@codecov Codecov
Copy link

codecov bot commented Nov 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.61111% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.57%. Comparing base (72889d1) to head (fcf9833).

Files with missing lines Patch % Lines
src/tmp.jl 96.29% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #926      +/-   ##
==========================================
- Coverage   99.17%   96.57%   -2.61%     
==========================================
  Files          29       30       +1     
  Lines        1209     1196      -13     
==========================================
- Hits         1199     1155      -44     
- Misses         10       41      +31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abelsiqueira abelsiqueira added the benchmark PR only - Run benchmark on PR label Nov 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024 •
edited
Loading

Benchmark Results

72889d1... fcf9833... 72889d1.../fcf98337ab1aae...
energy_problem/create_model 44.7 ± 1.9 s 42.4 ± 1.3 s 1.05
energy_problem/input_and_constructor 11.6 ± 0.45 s 16.2 ± 0.0036 s 0.718
time_to_load 4.02 ± 0.049 s 4.02 ± 0.0043 s 1
72889d1... fcf9833... 72889d1.../fcf98337ab1aae...
energy_problem/create_model 0.647 G allocs: 21.9 GB 0.673 G allocs: 21.3 GB 1.03
energy_problem/input_and_constructor 0.0329 G allocs: 1.39 GB 0.0693 G allocs: 2.62 GB 0.53
time_to_load 0.157 k allocs: 11.1 kB 0.157 k allocs: 11.1 kB 1

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@abelsiqueira abelsiqueira changed the title 923 variable refactor wip Create all variables directly from connection and independent of dataframes Nov 14, 2024
@abelsiqueira abelsiqueira mentioned this pull request Nov 14, 2024
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
benchmark PR only - Run benchmark on PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor variables
1 participant
@abelsiqueira