Move to GCC 9 to build on Travis #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codeplea would you consider to publish the binary again? |
|
Yeah, I can do that. Why do you need it though? Are the current binaries not compatible? Or do you just need one of the 2 that didn't compile before? I'm trying to better understand the use-case. |
|
The project I am working on need to work on both the active LTS (v14) and next active LTS (v16) Node version. It can help to reduce the compilation time needed for CI if prebuilt binary are available. As v16 is going to enter the active LTS on 2021-10-26, it is something nice but not urgent to have. |
|
thank you! |
deman4ik
pushed a commit
to deman4ik/tulipnode
that referenced
this pull request
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to GCC 9 to build on Travis (it is the default GCC version bundled with the LTS version of Ubuntu 20.04).
This resolves the error from the Travis log https://app.travis-ci.com/github/TulipCharts/tulipnode/jobs/529812363#L330 as the command is not available before g++ version 4.9 .
References:
nodejs/node#37935
https://stackoverflow.com/questions/39871129/c-error-unrecognized-command-line-option-std-gnu14