fix: better parse sci notation with + and -
#55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrySound
reviewed
Aug 5, 2019
test/unit.js
Outdated
| }, | ||
| { | ||
| fixture: "1.1e--++1e", | ||
| expected: { number: "1.1e-", unit: "-++1e" } |
Collaborator
Author
There was a problem hiding this comment.
@TrySound no, we already stop parsing for second e, so i use same logic for + and -
Collaborator
Author
There was a problem hiding this comment.
Our fixtures contain:
{
fixture: "2.",
expected: { number: "2.", unit: "" }
},
2. is not valid number too 😄 (in css)
alexander-akait
force-pushed
the
issue-54
branch
from
c87a890 to
6e5b710
Compare
Collaborator
Author
|
/cc @TrySound my mistake |
TrySound
approved these changes
Aug 5, 2019
Collaborator
Author
|
/cc @TrySound should we fix |
Owner
|
Yep. Looks like it's the wrong case. Don't really remember why I added it. |
Collaborator
Author
|
@TrySound 👍 i will send a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #54
/cc @TrySound