Skip to content

Added Node 24 to test matrix#1718

Open
kevinansfield wants to merge 2 commits intomainfrom
add-node-24-ci
Open

Added Node 24 to test matrix#1718
kevinansfield wants to merge 2 commits intomainfrom
add-node-24-ci

Conversation

@kevinansfield
Copy link
Member

no issue

  • we want to add Node 24.x support to packages ready for Ghost adding support for next LTS
  • --ignore-engines is needed because packages do not yet have updated engine support lists

@coderabbitai
Copy link

coderabbitai bot commented Jan 28, 2026

Walkthrough

The pull request updates the CI workflow to test on Node.js versions 22.13.1 and 24, and adds a step that runs yarn config set ignore-engines true before installing dependencies. Additionally, two package.json files are changed to bump the devDependency @playwright/test (in packages/kg-unsplash-selector and packages/koenig-lexical) to ^1.58.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the primary change: adding Node 24 to the test matrix in the GitHub workflow file.
Description check ✅ Passed The description is directly related to the changeset, explaining the rationale for adding Node 24 support and the need for ignoring engine checks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

no issue

- we want to add Node 24.x support to packages ready for Ghost adding support for next LTS
- `--ignore-engines` is needed because packages do not yet have updated engine support lists
no issue

- required for Node 24 compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant