Skip to content

🏎 Ran post growth stats aggregates in parallel #29704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
9larsons merged 2 commits into from
Aug 3, 2026
+27 −23
Merged

🏎 Ran post growth stats aggregates in parallel #29704

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04ec3b8
🏎 Ran post growth stats aggregates in parallel
irontaek Jul 31, 2026
ddedf10
Removed brittle growth stats concurrency test
9larsons Aug 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 27 additions & 23 deletions ghost/core/core/server/services/stats/posts-stats-service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,29 +399,33 @@ class PostsStatsService {

async getGrowthStatsForPost(postId) {
try {
const freeMembers = await this.knex('members_created_events as mce')
.countDistinct('mce.member_id as free_members')
.leftJoin('members_subscription_created_events as msce', function () {
this.on('mce.member_id', '=', 'msce.member_id')
.andOn('mce.attribution_id', '=', 'msce.attribution_id');
})
.where('mce.attribution_id', postId)
.whereIn('mce.attribution_type', ['post', 'page'])
.where('msce.id', null);

const paidMembers = await this.knex('members_subscription_created_events as msce')
.countDistinct('msce.member_id as paid_members')
.where('msce.attribution_id', postId)
.whereIn('msce.attribution_type', ['post', 'page']);

const mrr = await this.knex('members_subscription_created_events as msce')
.sum('mpse.mrr_delta as mrr')
.join('members_paid_subscription_events as mpse', function () {
this.on('mpse.subscription_id', '=', 'msce.subscription_id');
this.andOn('mpse.member_id', '=', 'msce.member_id');
})
.where('msce.attribution_id', postId)
.whereIn('msce.attribution_type', ['post', 'page']);
// The three aggregates only depend on postId, so run them together:
// the wait becomes the slowest query instead of the sum of all three.
const [freeMembers, paidMembers, mrr] = await Promise.all([
this.knex('members_created_events as mce')
.countDistinct('mce.member_id as free_members')
.leftJoin('members_subscription_created_events as msce', function () {
this.on('mce.member_id', '=', 'msce.member_id')
.andOn('mce.attribution_id', '=', 'msce.attribution_id');
})
.where('mce.attribution_id', postId)
.whereIn('mce.attribution_type', ['post', 'page'])
.where('msce.id', null),

this.knex('members_subscription_created_events as msce')
.countDistinct('msce.member_id as paid_members')
.where('msce.attribution_id', postId)
.whereIn('msce.attribution_type', ['post', 'page']),

this.knex('members_subscription_created_events as msce')
.sum('mpse.mrr_delta as mrr')
.join('members_paid_subscription_events as mpse', function () {
this.on('mpse.subscription_id', '=', 'msce.subscription_id');
this.andOn('mpse.member_id', '=', 'msce.member_id');
})
.where('msce.attribution_id', postId)
.whereIn('msce.attribution_type', ['post', 'page'])
]);

return {
data: [
Expand Down
Loading