Removed unnecessary Sentry captures for HTML parse failures#26891
Removed unnecessary Sentry captures for HTML parse failures#26891kevinansfield wants to merge 1 commit intomainfrom
Conversation
closes https://linear.app/ghost/issue/BER-3441/ HTML-to-mobiledoc/lexical parse errors are client input validation failures, not unexpected server errors. The explicit sentry.captureException() calls were sending these to Sentry before re-throwing as ValidationError (422), causing excessive noise when integrations retry bad requests.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
WalkthroughThis pull request removes Sentry error reporting integration from two serializer files. The 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
closes https://linear.app/ghost/issue/BER-3441/
HTML-to-mobiledoc/lexical parse errors from
?source=htmlrequests are client input validation failures, not unexpected server errors. The explicitsentry.captureException()calls were reporting these to Sentry before re-throwing asValidationError(422), causing excessive noise when integrations retry bad requests. TheValidationErroralone is sufficient — clients get a proper 422 and Ghost's error middleware already knows not to report 4xx errors to Sentry.