🐛 Fixed reply form showing parent comment author's details#25858
🐛 Fixed reply form showing parent comment author's details#25858
Conversation
WalkthroughForm and FormWrapper components now derive memberName and memberExpertise only from Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings🧬 Code graph analysis (1)apps/comments-ui/src/components/content/forms/reply-form.tsx (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (1)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
kevinansfield
left a comment
There was a problem hiding this comment.
Left a comment about a similar fallback issue with member name, although that's a little more of an edge-case. Otherwise looks good 👌
1845c45 to
88ac2cd
Compare
88ac2cd to
cd222d7
Compare
ref https://linear.app/ghost/issue/BER-3212 When a user opened a reply form, the form header was showing the parent comment author's name and expertise instead of the current user's data. This happened because the code used a fallback pattern that pulled from the comment being replied to when the current member had no value set.
cd222d7 to
a1cd570
Compare
Summary
When opening a reply form on a comment, the form header was incorrectly displaying the parent comment author's name and expertise instead of the current user's data. This happened because the code used fallback patterns that pulled values from the comment being replied to when the current member had no name or expertise set.
The fix removes these fallbacks so the reply form only shows the logged-in user's own details (or the appropriate placeholder if they have none).
ref https://linear.app/ghost/issue/BER-3212