Conversation
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Code Standards on the wiki say: "Indent with 4 spaces" ;) Grunt is awesome, automating things is awesome and I really appreciate that you've done this. However, the validation needs to please follow the JSLint standards with the option nomen:true set. |
|
No problem. I'm gonna convert the indentation and add the nomen: true and re-submit the PR. Have to go out for mothers day activities tonight so it will probably be later. |
|
You will need to also either convert to using grunt-jslint or figure out Currently, the commit you did to fix a JSHint rule breaks two JSLint rules! Have fun tonight, I'm off for some beauty sleep :) Sent from my iPhone On 12 May 2013, at 22:25, Jacob Gable notifications@github.com wrote: No problem. I'm gonna convert the indentation and add the nomen: true and Have to go out for mothers day activities tonight so it will probably be — |
|
Still looking into whether jshint can behave exactly like jslint. The grunt-jslint task I've found is pretty old and I'd rather not use it. When you run jslint, is a command line thing or though an IDE? Do you just run it with the default options? |
|
Ok, found out that the Seems to be linting pretty strictly now, including the 4 spaces for indentation. |
|
From JSLint: "Tolerate dangling _ in identifiers - nomen: true if names should not be checked for initial or trailing underbars." nomen:true should turn the dangling _ check off, not on :/ |
|
Sorry, to answer the question about JSLint it is built into my IDE (IntellliJ) and then I usually have a ci build as back up :) |
|
Ok, I think this is pretty close now. Switched over to jslint task and |
feat(grunt): Introducing "dryrun" grunt task for development usage
Refs #23 Corresponding HTML is located at https://github.com/TryGhost/Ghost/pull/3155/files
Refs #23 Corresponding HTML is located at https://github.com/TryGhost/Ghost/pull/3155/files
Refs #23 Corresponding HTML is located at https://github.com/TryGhost/Ghost/pull/3155/files
Initial Grunt configuration
Issue 18 - added pre_restart_nodejs to address problem NODE_ENV variable
Issue 18 - added pre_restart_nodejs to address problem NODE_ENV variable
* Corrected the event handling of layer0 * Updated layer1 to use layer0 * Updated dropin script to read blogUrl from window;
2 participants
I'm not sure how you feel about grunt, but this is my attempt at a basic grunt config for the project.
Right now, it's setup with some basic jshinting and nodeunit tasks. As well as a
grunt inittask that will compile the admin styles. The jshint options can be controlled through the .jshintrc file in the root and as long as new nodeunit files are named liketest-*.jsthey will automatically get added when runninggrunt validate.I didn't see anything in the style guide about tabs vs. spaces. But we can add that to the jshint options as well.
Let me know how you feel about it.