Skip to content

Conversation

mike182uk
Copy link
Member

ref https://linear.app/ghost/issue/PROD-2455
ref TryGhost/Ghost#24985

The admin-x-activitypub script has been renamed to just activitypub so the client config endpoint should be updated to reflect this change

ref https://linear.app/ghost/issue/PROD-2455
ref TryGhost/Ghost#24985

The `admin-x-activitypub` script has been renamed to just `activitypub` so the
client config endpoint should be updated to reflect this change
Copy link

cursor bot commented Sep 25, 2025

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on October 3.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Copy link

coderabbitai bot commented Sep 25, 2025

Walkthrough

The client identifier in the backend-driven frontend configuration was renamed from "admin-x-activitypub" to "activitypub". This change updates the emitted JSON values and the constructed CDN URL to reference the "activitypub" bundle instead of "admin-x-activitypub". No control flow, version derivation, or error handling logic was modified. An ADR document was updated to reflect the same renaming in documentation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title clearly describes the main change, namely updating the client config controller to reference the renamed script, and does so in concise, specific language that a reviewer can quickly understand.
Description Check ✅ Passed The pull request description directly relates to the changeset by referencing the rename of the admin-x-activitypub script to activitypub and explaining that the client config endpoint was updated accordingly, making it clearly on-topic.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mike-prod-2455-rename-admin-x-activitypub-to-activitypub-in-ghost

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1b11d9a and 2e37743.

📒 Files selected for processing (2)
  • adr/0002-frontend-backend-versioning.md (1 hunks)
  • src/http/api/client-config.controller.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
src/**/*.ts

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*.ts: Never use direct string comparisons for ActivityPub IDs; use SHA256 hash-based lookups instead
Use Result helper functions (isError, getError, getValue) and avoid destructuring Result values directly
Awilix uses CLASSIC injection: constructor parameter names must match their registration names
Define routes using decorators rather than direct registration
Prefer immutable entities that emit domain events over mutable entities with dirty flags
Use structured error objects with context in Result types instead of string literals
Prefer class-based handlers with dependency injection over function factories

Files:

  • src/http/api/client-config.controller.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build / Build Docker Images (linux/amd64, amd64)
🔇 Additional comments (2)
src/http/api/client-config.controller.ts (1)

8-12: Rename aligns with new bundle naming.

The client identifier and CDN URL now match the renamed activitypub bundle as expected.

adr/0002-frontend-backend-versioning.md (1)

65-68: Docs correctly mirror the runtime rename.

The ADR now references the activitypub package and CDN URL, keeping the documentation consistent with the implementation.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant