Skip to content

Conversation

mike182uk
Copy link
Member

ref https://linear.app/ghost/issue/PROD-2675

The cleanup-expired-key-value-records job is no longer needed as now all ephemeral data is stored in Redis (Redis will clean up expired data automatically)

ref https://linear.app/ghost/issue/PROD-2675

The `cleanup-expired-key-value-records` job is no longer needed as now all
ephemeral data is stored in Redis (Redis will clean up expired data
automatically)
Copy link

coderabbitai bot commented Sep 25, 2025

Walkthrough

This change removes the cleanup-expired-key-value-records job and its related tooling. Specifically: the GitHub Actions workflow block that built and pushed the cleanup job image is deleted; two docker-compose services for the cleanup task (including testing) are removed; the job’s Dockerfile and shell script are deleted; and the package.json script for invoking the cleanup via Docker Compose is removed. Additionally, the Renovate configuration narrows a disabled rule’s matchPaths to only jobs/populate-explore-json/**, removing two other job paths from that rule.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly describes the primary change of removing the redundant cleanup-expired-key-value-records job without extraneous detail or vague language, reflecting the main focus of the pull request.
Description Check ✅ Passed The description clearly states the reason for removing the cleanup-expired-key-value-records job and references the relevant issue, directly matching the changeset that removes that job from various configurations.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mike-prod-2675-remove-redundant-cleanup-expired-key-value-records-job

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

{
// Exclude dependencies in jobs that don't have automated tests
"matchPaths": ["jobs/populate-explore-json/**", "jobs/cleanup-expired-key-value-records/**", "jobs/update-external-accounts/**"],
"matchPaths": ["jobs/populate-explore-json/**"],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Renovate Configuration Error Exposes Unintended Paths

The Renovate configuration in .github/renovate.json5 unintentionally removed jobs/update-external-accounts/** from the matchPaths array. This path was intended to remain excluded, as the job lacks automated tests, meaning Renovate will now manage its dependencies.

Fix in Cursor Fix in Web

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jobs/update-external-accounts was a leftover - The job no longer exists. Its safe to remove 👍

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1b11d9a and a6f286f.

📒 Files selected for processing (6)
  • .github/renovate.json5 (1 hunks)
  • .github/workflows/build.yml (0 hunks)
  • docker-compose.yml (0 hunks)
  • jobs/cleanup-expired-key-value-records/Dockerfile (0 hunks)
  • jobs/cleanup-expired-key-value-records/cleanup-expired-key-value-records (0 hunks)
  • package.json (0 hunks)
💤 Files with no reviewable changes (5)
  • package.json
  • .github/workflows/build.yml
  • jobs/cleanup-expired-key-value-records/Dockerfile
  • docker-compose.yml
  • jobs/cleanup-expired-key-value-records/cleanup-expired-key-value-records
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build / Build Docker Images (linux/amd64, amd64)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant