Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm having a pretty bad crash in the "Trenches" level when I destroy a turret with the revolver.
This doesn't happen with the precompiled v2.2.1. The latest working build is with the commit: 71f14cd
The commit af636f5 makes impossible to load the savegame. The savegame crash was fixed in commit 4ab826e but here there is the crash mentioned above with turret explosions.
This is the savegame file: savegame.zip
Load it, aim with the revolver by pressing the PAD0 and shoot the small white tank positioned behind the turret, the game will crash with the latest build compiled from master branch.
Let me start by saying that I'm not a programmer, I only have very basic knowledge of C++, I looked for a simple solution that would allow me to complete the game. For the moment I have not experienced any other crashes.
The crash seems to be caused by these two pieces of code in output.cpp:
Anyway, I managed to prevent the game from crashing after the turret explosion moving
current_item = 0;
before loading a level instead of output.cpp, as mentioned in the PR.It seems to work with this other solution too:
file.cpp
As already said, I'm not a programmer, so if this isn't the ideal solution for you, you can close the PR, but since no one is interested in it for the moment, I think this is better than nothing 😅.
I attach the compiled executable for testing (the "crocodile underwater death animation" fix by TokyoSU is also included): tomb4.zip