Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exponential gradient reduction without protected attribute (#267) #268

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Fix exponential gradient reduction without protected attribute (#267) #268

merged 1 commit into from
Sep 7, 2021

Conversation

jdnklau
Copy link
Contributor

@jdnklau jdnklau commented Sep 6, 2021

Fixes #267.

  • Exponential Gradient Reduction with drop_prot_attr=True lead to errors when calling predict_proba.
  • This is due to the call `X.drop(self.prot_attr) in the function
  • Should be X.drop(self.prot_attr, axis=1) to go over the dataframe's columns (cf. call in predict)
  • This PR fixes exactly that

@nrkarthikeyan
Copy link
Collaborator

PR approved and merged

@nrkarthikeyan nrkarthikeyan merged commit 2c09e2f into Trusted-AI:master Sep 7, 2021
@hoffmansc hoffmansc mentioned this pull request Aug 29, 2022
Closed
Illia-Kryvoviaz pushed a commit to Illia-Kryvoviaz/AIF360 that referenced this pull request Jun 7, 2023
@nrkarthikeyan
Merge pull request Trusted-AI#268 from jdnklau/master
29e8a3c 
Fix exponential gradient reduction without protected attribute (Trusted-AI#267)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrkarthikeyan nrkarthikeyan nrkarthikeyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExponentiatedGradientReduction does not work for drop_prot_attr=True, needs one-line fix
2 participants
@jdnklau @nrkarthikeyan