Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasm-timer to wasmtimer #202

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pvichivanives
Copy link
Contributor

@pvichivanives pvichivanives commented Nov 27, 2024

Swaps over to wasmtimer, an updated library from wasm-timer which is not maintained.
Closes #199
See here for fork: google/tarpc#388

@pvichivanives pvichivanives requested a review from a team as a code owner November 27, 2024 00:17
Copy link
Member

@eopb eopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🙌

One thing needs to be changed

@@ -24,14 +24,14 @@ reqwest = { version = "0.12.0", default-features = false }
retry-policies = "0.4"
thiserror = "1.0.61"
tracing = { version = "0.1.26", optional = true }
wasmtimer = "0.4.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to gate this dependency behind cfg(target_arch = "wasm32") like we did before

@pvichivanives pvichivanives requested a review from eopb December 5, 2024 01:39
@edevil
Copy link

edevil commented Dec 16, 2024

lgtm, but the change has conflicts now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

RUSTSEC-2024-0384: instant is unmaintained
3 participants