Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry 0.24 support #171

Merged
merged 4 commits into from
Jul 30, 2024
Merged

OpenTelemetry 0.24 support #171

merged 4 commits into from
Jul 30, 2024

Conversation

mladedav
Copy link
Contributor

Updates and hopefully fixes #168

Building doesn't seem to work with --all-features but looking at it I don't think it ever worked with deprecated_attributes.

Feel free to just take the code and put it into the original PR or merge this.

@mladedav mladedav requested a review from a team as a code owner July 24, 2024 11:17
Copy link
Member

@eopb eopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR, LGTM 🙌

@eopb eopb merged commit 053d329 into TrueLayer:main Jul 30, 2024
9 checks passed
@mladedav mladedav deleted the dm/otel-0-24 branch July 30, 2024 09:44
@SimenB
Copy link
Contributor

SimenB commented Jul 31, 2024

Can this get a release? 🙂

@mladedav
Copy link
Contributor Author

mladedav commented Aug 5, 2024

@eopb Sorry to bump this, but can this get a (patch) release? This is hopefully the last thing we're waiting on to be able to update OpenTelemetry and move on to http@1.0.

Or are there some breaking changes in master and this waits for some other changes?

@eopb
Copy link
Member

eopb commented Aug 5, 2024

There's nothing blocking the next release. I just haven't had an opportunity to cut it yet. I'll make sure something happens in the coming days 👍

@eopb
Copy link
Member

eopb commented Aug 9, 2024

This has now been released 🎉

https://github.com/TrueLayer/reqwest-middleware/releases/tag/reqwest-tracing-v0.5.3

Sorry about the wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants