Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix awkward double query at finalStep #7

Open
hswick opened this issue Mar 22, 2018 · 0 comments
Open

Fix awkward double query at finalStep #7

hswick opened this issue Mar 22, 2018 · 0 comments

Comments

@hswick
Copy link
Contributor

hswick commented Mar 22, 2018

See basic_verification_game.js query to highStep for an example of this. Solution would be to able to run the test without using the second query.

The issue is because performStepVerification needs lowStep + 1 == highStep. If one doesn't query again, then lowStep doesn't get set.

highStep, lowStep get changed by query/response.

So the fix will belong in the logic in the query method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant