Mock unit tests #48
Merged
Mock unit tests #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add types to model attributes (supporting PHP 7.4) * Move the HTTP client to the API client * Move the API configuration to the API client * Rename the Patreon get method in the Player model * Deprecate the company role get method in the Player model * Fix the start_at type in the Event model * Fix parameter types for the company key in requests * Fix the ProMods name in the Server model
bensherred
approved these changes
Feb 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a little bit more complicated due to the necessary underlying changes. For example, one of the major changes, which is backward compatible but breaks tests, is creating a base class for entity models. This is a common approach in API libraries and helps to share the basic client around. This makes additional requests much easier.
I include the whole change list below to make reviewing this pull request as easy as possible.
Closes #30.
Deprecations
getConfirmed()andgetUnsure()methods of theEventAttendancemodel in favor of the existing collectionsPlayer::getCompanyRole()due to another unexpected internal requestPlayer::patreon()in favor of the newPlayer::getPatreon()getterFeatures
Fixes
start_attype inEventServerChanges