Multiple driver errors caused by invalid return type of `driverRead()`

[ShockedPlot7560]

Configuration

• PhpFastCache version: 9.0.2
• PhpFastCache API version: 4.0.0
• PHP version: 8.0.13
• Operating system: Ubuntu

Describe the bug

I don't really know the nature of the bug, but it seems to come from the File driver Phpfastcache\Drivers\Files\Driver::driverRead()

To Reproduce
Code to reproduce the issue:

/** @var ExtendedCacheItemPoolInterface */
$cacheManager = $this->container->get(CacheManager::class);
$cacheString = "SimplyString";
$cacheItem = $cacheManager->getItem($cacheString);

Driver used : files

Stacktrace

TypeError: Phpfastcache\Drivers\Files\Driver::driverRead(): Return value must be of type ?array, bool returned in /var/www/html/vendor/phpfastcache/phpfastcache/lib/Phpfastcache/Drivers/Files/Driver.php:74
Stack trace:
#0 /var/www/html/vendor/phpfastcache/phpfastcache/lib/Phpfastcache/Core/Pool/CacheItemPoolTrait.php(132): Phpfastcache\Drivers\Files\Driver->driverRead(Object(Phpfastcache\Drivers\Files\Item))
#1 /var/www/html/src/core/middleware/MaintenanceMiddleware.php(32): Phpfastcache\Drivers\Files\Driver->getItem('MaintenanceAuto...')
...
#7 {main}

[github-actions]

Hello curious contributor !
Since it seems to be your first contribution, make sure that you've been:

• Reading and searching out our WIKI
• Reading and agreed with our Code Of Conduct
• Reading and understood our Coding Guideline
• Reading our README
  If everything looks unclear to you, tell us what 😄
  The Phpfastcache Team

[aemla]

I have the same issue with Memcached driver.

• PhpFastCache version: 9.1.0
• PHP version: 8.0.17
• Operating system: Ubuntu

PHP Fatal error:  Uncaught TypeError: Phpfastcache\Drivers\Memcached\Driver::driverRead(): Return value must be of type ?array, string returned in /public_html/vendor/phpfastcache/phpfastcache/lib/Phpfastcache/Drivers/Memcached/Driver.php:154
Stack trace:
#0 /public_html/vendor/phpfastcache/phpfastcache/lib/Phpfastcache/Core/Pool/CacheItemPoolTrait.php(132): Phpfastcache\Drivers\Memcached\Driver->driverRead()
#1 /public_html/controller/Controller.php(61): Phpfastcache\Drivers\Memcached\Driver->getItem()
...
#4 {main}
  thrown in /public_html/vendor/phpfastcache/phpfastcache/lib/Phpfastcache/Drivers/Memcached/Driver.php on line 154

[Geolim4]

This behavior is very surprising as all tests would have been broken if such behavior would happens.

Did you decorated Phpfastcache services or something ?

If you see in /tests lot of call to getItem are made, especially with Files driver.

(See ReadWriteOperations.test.php)

[Geolim4]

Can you please post your full code implementation below ?

Because this is the very first time report me this kind of issue that should be impossible to produce, especially with LOT of tests calling getItem().

[Geolim4]

I have the same issue with Memcached driver.

* **PhpFastCache version:** 9.1.0

* **PHP version:** 8.0.17

* **Operating system:** Ubuntu

PHP Fatal error:  Uncaught TypeError: Phpfastcache\Drivers\Memcached\Driver::driverRead(): Return value must be of type ?array, string returned in /public_html/vendor/phpfastcache/phpfastcache/lib/Phpfastcache/Drivers/Memcached/Driver.php:154
Stack trace:
#0 /public_html/vendor/phpfastcache/phpfastcache/lib/Phpfastcache/Core/Pool/CacheItemPoolTrait.php(132): Phpfastcache\Drivers\Memcached\Driver->driverRead()
#1 /public_html/controller/Controller.php(61): Phpfastcache\Drivers\Memcached\Driver->getItem()
...
#4 {main}
  thrown in /public_html/vendor/phpfastcache/phpfastcache/lib/Phpfastcache/Drivers/Memcached/Driver.php on line 154

Can't reproduce it neither, I'm gonna need more information with your full code implementation.
For confidentiality you can send me sensible code at contact at geolim4.com

[ShockedPlot7560]

Hello,
The error also seems very strange to me and never happens in local but only in production.
I will detail below the architecture likely to make a bug and will take the simplest case which brings me this error :

Before anything, I use the PHP-DI container for dependency injection that I build like this:

$buildeur = new ContainerBuilder();
$buildeur->addDefinitions($pathToConfigFile);
$buildeur->enableCompilation(__ROOT_FOLDER . "/tmp");
$container = $buildeur->build();

The configuration file is of type:

<?php

use DI\Container;
use Phpfastcache\CacheManager;
use Phpfastcache\Config\ConfigurationOption;

require __ROOT_FOLDER . "/vendor/autoload.php";

return [
	CacheManager::class => function (Container $container) {
		$instance = $container->get("ENV") === "dev" ? "Devnull" : "files";
		CacheManager::setDefaultConfig(new ConfigurationOption([
			"path" => $container->get("tmp.path")
		]));
		return CacheManager::getInstance($instance);
	}
];

After that, so the compilation of the container has been defined, and phpfastcache and DI share the same tmp/ directory.
A case that I have a problem with is going to be below. Or, the code that seems to be problematic anyway, a very trivial value retrieval and saving code.

//I have simplified the operation and removed the portions of code that are not necessary and do not interfere
$pdo = $container->get(PDO::class);
/** @var ExtendedCacheItemPoolInterface */
$cacheManager = $container->get(CacheManager::class);
$cacheString = "Maintenance";
$cacheItem = $cacheManager->getItem($cacheString);
if ($config["maintenance"] !== true && $pdo !== null) {
	$cacheItem->set(false)->expiresAfter(3600 * 24);
	$cacheManager->save($cacheItem);
} else {
	if($pdo === null){
		if($cacheItem->get() === false || $cacheItem->get() === null){
			// send notification to discord
		}
		if(!$cacheItem->isHit()){
			$cacheItem->set(true)->expiresAfter(3600 * 24);
		}
		$cacheManager->save($cacheItem);
	}
}

[Geolim4]

I think you are facing race condition issue with Files driver.
Try to enable the option preventCacheSlams (only for Files driver), see Wiki.

Also I suggest you a better approach with the CacheManager.

Instead of calling:

		CacheManager::setDefaultConfig(new ConfigurationOption([
			"path" => $container->get("tmp.path")
		]));

Try to do:

		return CacheManager::getInstance($instance, [
		    'path' => $container->get("tmp.path"),
		    'preventCacheSlams' => true,
                ]);
                // OR

Also try a more performant driver like Redis if you can, this will be more appropriated for heavy cache usage.

[ShockedPlot7560]

I'll try your answer, however regarding the Redis driver, it takes, I guess a lot of memory space?

[Geolim4]

Not at all, redis is one of the lightweight memory backend I know. It is popular because of its efficiency and few ressources needed 😁 But first try to enable the option I suggested above.

[ShockedPlot7560]

Update after testing in production (where it crashes). The error is always launched having set the configuration as requested. I will try to switch to the Redis driver to see if it still happens or not.

[Geolim4]

How many request per second do you have ?

Can you invit me to talk on discord maybe ? :)