Skip to content

Commit

Permalink
src: remove icuDataDir from node config
Browse files Browse the repository at this point in the history
icuDataDir seems to be redundant as it is not used anywhere.
Hence removing it.

PR-URL: nodejs#24780
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
  • Loading branch information
GauthamBanasandra authored and Trott committed Dec 15, 2018
1 parent 06134e3 commit 9021b0d
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/node_config.cc
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,6 @@ static void Initialize(Local<Object> target,
READONLY_TRUE_PROPERTY(target, "hasNodeOptions");
#endif

// TODO(addaleax): This seems to be an unused, private API. Remove it?
READONLY_STRING_PROPERTY(target, "icuDataDir",
per_process_opts->icu_data_dir);

#endif // NODE_HAVE_I18N_SUPPORT

if (env->options()->preserve_symlinks)
Expand Down

0 comments on commit 9021b0d

Please sign in to comment.