test: fix test-dns-idna2008.js

The test should pass if ESERVFAIL is the result. Refs: nodejs#25870 (comment)
Trott · Apr 13, 2019 · 4fd2912 · 4fd2912
1 parent 9b6b567
commit 4fd2912
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/test/internet/test-dns-idna2008.js b/test/internet/test-dns-idna2008.js
@@ -43,11 +43,21 @@ dns.promises.lookup(fixture.hostname).then(({ address }) => {
 }).finally(mustCall());
 
 dns.resolve4(fixture.hostname, mustCall((err, addresses) => {
+  if (err && err.errno === 'ESERVFAIL') {
+    assert.ok(err.message.includes('queryA ESERVFAIL straße.de'));
+    return;
+  }
   assert.ifError(err);
   assert.deepStrictEqual(addresses, [fixture.expectedAddress]);
 }));
 
 const p = new dns.promises.Resolver().resolve4(fixture.hostname);
-p.then(mustCall((addresses) => {
+p.then((addresses) => {
   assert.deepStrictEqual(addresses, [fixture.expectedAddress]);
-}));
+}, (err) => {
+  if (err && err.errno === 'ESERVFAIL') {
+    assert.ok(err.message.includes('queryA ESERVFAIL straße.de'));
+  } else {
+    throw err;
+  }
+}).finally(mustCall());