Skip to content

Conversation

@yordis
Copy link
Member

@yordis yordis commented Sep 30, 2025

Problem

Archive names are unnecessarily long and duplicate the component name:

protoc-gen-elixir-grpc_protoc-gen-elixir-grpc@v0.2.0_Darwin_arm64.tar.gz
                      ^^^^^^^^^^^^^^^^^^^^^^^^
                      duplicated!

Root Cause

The GoReleaser archive template was using:

{{ .Env.BUILD_COMPONENT }}_{{- .Version }}_...

Where:

  • BUILD_COMPONENT = protoc-gen-elixir-grpc
  • .Version = protoc-gen-elixir-grpc@v0.2.0 (full monorepo tag)

This resulted in the component name appearing twice.

Solution

Remove the {{ .Env.BUILD_COMPONENT }} prefix from the archive template since .Version already contains the full monorepo tag format.

Result

Cleaner archive names:

protoc-gen-elixir-grpc@v0.2.0_Darwin_arm64.tar.gz
protoc-gen-elixir-grpc@v0.2.0_Linux_x86_64.tar.gz
protoc-gen-elixir-grpc@v0.2.0_Windows_x86_64.tar.gz

Testing

Validated locally with:

BUILD_COMPONENT="protoc-gen-elixir-grpc" goreleaser release --snapshot --skip=validate

@coderabbitai
Copy link

coderabbitai bot commented Sep 30, 2025

Warning

Rate limit exceeded

@yordis has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 1 minutes and 49 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 626a842 and a5abaea.

📒 Files selected for processing (1)
  • .github/goreleaser.yml (0 hunks)
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/archive-naming

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

The archive name was duplicating the component name:
- Before: protoc-gen-elixir-grpc_protoc-gen-elixir-grpc@v0.2.0_Darwin_arm64.tar.gz
- After:  protoc-gen-elixir-grpc@v0.2.0_Darwin_arm64.tar.gz

Since .Version now contains the full monorepo tag (component@version), we don't need to prefix it with BUILD_COMPONENT.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis merged commit 9fe6682 into main Sep 30, 2025
3 checks passed
@yordis yordis deleted the fix/archive-naming branch September 30, 2025 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants