Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: TrogonStack/protoc-gen
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: protoc-gen-connect-go-servicestruct@v0.1.1
Choose a base ref
...
head repository: TrogonStack/protoc-gen
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: protoc-gen-connect-go-servicestruct@v0.2.0
Choose a head ref
  • 8 commits
  • 15 files changed
  • 2 contributors

Commits on Sep 29, 2025

  1. feat(protoc-gen-elixir-gprc): add elixir grpc plugin (#11)

    Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
    yordis authored Sep 29, 2025
    Configuration menu
    Copy the full SHA
    8bcc1c4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    650ffc0 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2025

  1. chore: add GoReleaser (#13)

    Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
    yordis authored Sep 30, 2025
    Configuration menu
    Copy the full SHA
    8482c48 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    43d354a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    46a7854 View commit details
    Browse the repository at this point in the history
  4. fix(cd): allow GoReleaser to auto-detect monorepo tags and skip semve…

    …r validation (#17)
    
    ## Problem
    
    The GoReleaser step in the CD workflow was failing with the error:
    ```
    git tag v0.2.0 was not made against commit 46a7854
    ```
    
    ## Root Cause Analysis
    
    The workflow was overriding `GORELEASER_CURRENT_TAG` with just the
    semantic version (`v0.2.0`), but the actual git tag created by
    release-please uses the full monorepo format
    (`protoc-gen-elixir-grpc@v0.2.0`).
    
    When tested locally:
    - **Setting `GORELEASER_CURRENT_TAG=v0.2.0`** → `git tag v0.2.0 was not
    made against commit...` ❌
    - **Setting `GORELEASER_CURRENT_TAG=protoc-gen-elixir-grpc@v0.2.0`** →
    `failed to parse tag as semver: invalid semantic version` ❌
    - **Removing `GORELEASER_CURRENT_TAG` entirely** → GoReleaser
    auto-detects the full tag correctly, but semver validation fails ⚠️
    
    ## Solution
    
    1. **Remove `GORELEASER_CURRENT_TAG`** - Let GoReleaser auto-detect the
    tag from git (it correctly finds `protoc-gen-elixir-grpc@v0.2.0`)
    2. **Add `--skip=validate` flag** - Bypass semver validation since our
    tags use `component@version` format
    
    ## Local Validation
    
    Dry-run test confirmed the fix works:
    ```bash
    BUILD_COMPONENT="protoc-gen-elixir-grpc" goreleaser release --clean --skip=publish,validate
    ```
    
    Results:
    - ✅ Auto-detected tag: `protoc-gen-elixir-grpc@v0.2.0`
    - ✅ Built all 6 binaries successfully (darwin/linux/windows,
    amd64/arm64)
    - ✅ Generated correct build artifacts with version
    `protoc-gen-elixir-grpc@v0.2.0`
    
    ## Impact
    
    This fix enables the release workflow to properly handle monorepo tags
    for both:
    - `protoc-gen-elixir-grpc`
    - `protoc-gen-connect-go-servicestruct`
    
    Fixes:
    https://github.com/TrogonStack/protoc-gen/actions/runs/18118813863/job/51559613751
    
    Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
    yordis authored Sep 30, 2025
    Configuration menu
    Copy the full SHA
    626a842 View commit details
    Browse the repository at this point in the history
  5. fix: remove redundant component name from archive template (#18)

    ## Problem
    
    Archive names are unnecessarily long and duplicate the component name:
    ```
    protoc-gen-elixir-grpc_protoc-gen-elixir-grpc@v0.2.0_Darwin_arm64.tar.gz
                          ^^^^^^^^^^^^^^^^^^^^^^^^
                          duplicated!
    ```
    
    ## Root Cause
    
    The GoReleaser archive template was using:
    ```yaml
    {{ .Env.BUILD_COMPONENT }}_{{- .Version }}_...
    ```
    
    Where:
    - `BUILD_COMPONENT` = `protoc-gen-elixir-grpc`
    - `.Version` = `protoc-gen-elixir-grpc@v0.2.0` (full monorepo tag)
    
    This resulted in the component name appearing twice.
    
    ## Solution
    
    Remove the `{{ .Env.BUILD_COMPONENT }}` prefix from the archive template
    since `.Version` already contains the full monorepo tag format.
    
    ## Result
    
    Cleaner archive names:
    ```
    protoc-gen-elixir-grpc@v0.2.0_Darwin_arm64.tar.gz
    protoc-gen-elixir-grpc@v0.2.0_Linux_x86_64.tar.gz
    protoc-gen-elixir-grpc@v0.2.0_Windows_x86_64.tar.gz
    ```
    
    ## Testing
    
    Validated locally with:
    ```bash
    BUILD_COMPONENT="protoc-gen-elixir-grpc" goreleaser release --snapshot --skip=validate
    ```
    
    Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
    yordis authored Sep 30, 2025
    Configuration menu
    Copy the full SHA
    9fe6682 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    72d33a9 View commit details
    Browse the repository at this point in the history
Loading