Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOOLS-2545 CoC should be explicit #331

Merged
merged 2 commits into from
Apr 5, 2024
Merged

TOOLS-2545 CoC should be explicit #331

merged 2 commits into from
Apr 5, 2024

Conversation

bahamat
Copy link
Contributor

@bahamat bahamat commented Apr 4, 2024 •
edited
Loading

@bahamat bahamat requested review from danmcd and a team April 4, 2024 17:59
@bahamat bahamat mentioned this pull request Apr 4, 2024
Merged
danmcd
danmcd previously approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP IT!

This was referenced Apr 4, 2024
Merged
Merged
danmcd
danmcd reviewed Apr 4, 2024
View reviewed changes
Copy link
Contributor

@danmcd danmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Slack... "if we find a bug in house we use Jira, and a PR. If someone outside-the-house finds a bug, they use a github issue, which we then create a shadow Jira, and a PR." Also, use a TRITON-xxxx bug in the example.

@bahamat bahamat merged commit b370af0 into master Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danmcd danmcd danmcd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bahamat @danmcd