TOOLS-2315 document how to add to /Joyent_Dev/public/releng/go/adhoc for new go versions #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for new go versions
trentm
approved these changes
Mar 4, 2020
| rm -rf "pkg/obj" | ||
|
|
||
| # Remove the libraries used to build the toolchain commands. | ||
| rm -rf "pkg/illumos_amd64/cmd" |
There was a problem hiding this comment.
This go-build.sh only needs to support newer Go versions that use the "illumos" GOOS, right?
There was a problem hiding this comment.
Yes - I'm assuming here that we always only want to build a go runtime for illumos. That's certainly the platform we'll be running on, and given that a go runtime will cross-compile, if we want to declare 'solaris' when building any Triton/Manta component at build-time, we can do eg.
GOOS=solaris go build
even with our illumos binary. For now, that's actually the default in Makefile.go_prebuilt.targ. I mentioned that in TOOLS-2439.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.