Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOOLS-2404 joyent/rfd shouldn't need GitHub master branch protection #273

Merged
merged 2 commits into from
Jan 21, 2020
Merged

TOOLS-2404 joyent/rfd shouldn't need GitHub master branch protection #273

merged 2 commits into from
Jan 21, 2020

Conversation

timfoster
Copy link
Contributor

No description provided.

@timfoster timfoster requested a review from trentm January 21, 2020 14:50
trentm
trentm previously approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: tabs?

tools/jr-manifest.json Outdated
@@ -464,7 +469,8 @@
{
"name": "rfd",
"labels": {
"meta": true
"meta": true,
"nobranchprotection": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tabs?

@timfoster timfoster requested a review from trentm January 21, 2020 16:17
@timfoster timfoster merged commit 3b3340d into master Jan 21, 2020
@timfoster timfoster deleted the prr-TOOLS-2404 branch January 21, 2020 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentm trentm trentm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timfoster @trentm