Sync origin #2
Open
Sync origin #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* git-branch-done: merge --no-ff current topic branch to desired branch * git-merge-to: merge --ff current branch to desired branch * git-release: release work through CI/CD merging strategy
chore: Improve path quoting
chore: Fix miscellaneous bugs
chore: Fix POSIX shell syntax errors
chore: Fix most shell deprecations
chore: More Bash improvements
This commit fixes two issues in the git-find script: 1. Stack overflow in assign_name method: Converted from recursive to iterative implementation using a queue-based approach. This prevents stack overflow when processing commits with very deep parent chains or complex histories. The iterative version can handle arbitrarily deep chains without hitting Ruby's stack limit. 2. ARGV handling bug: Fixed incorrect treatment of ARGV[0] as an array. Changed ARGV[0] to ARGV on lines 186 and 243 to properly handle command line arguments. These changes resolve the SystemStackError reported when running git-find on repositories with complex commit histories like the official Git repo. Tested successfully on the Git repository with 78k+ commits using: git find bd40d252ec1ed2716ac9e6bbeab48b3b40bd0d58 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Fix stack overflow in git-find script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.