-
Notifications
You must be signed in to change notification settings - Fork 1
Aaron/robots page #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o added more resolutions to choose from in Join Us, I want to experiment with how this runs.
✅ Deploy Preview for trickfiredemo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Quashnock
added a commit
that referenced
this pull request
Sep 26, 2024
* Initial Overhaul Boilerplate * -Created the Header and Footer components. -Removed uneeded images and reorganized into photos and icons folders -Slightly altered html pages in order to accomodate change in component creation method and to improve accessibility and SEO. * Aaron/2024 join us (#43) * -Created the Header and Footer components -Removed uneeded images and reorganized into photos and icons folders -Slightly altered html pages in order to accomodate change in component creation method and to improve accessibility and SEO. * - Created initial Join Us page, content and animations still need to be updated in the future - Added logos folder in assets and moved all logos over from icons into logos. Existing references to logos in html code have been edited accordingly -Removed reference to Font Awesome in all HTML pages as those will likely be unused and will increase load times. -Added main overflow-x: hidden and max-width: 100% styles to keep content from overflowing to the sides of the screen --------- Co-authored-by: Quashnock <awq@uw.edu> * Aaron/2024 join us (#44) * -Created the Header and Footer components -Removed uneeded images and reorganized into photos and icons folders -Slightly altered html pages in order to accomodate change in component creation method and to improve accessibility and SEO. * - Created initial Join Us page, content and animations still need to be updated in the future - Added logos folder in assets and moved all logos over from icons into logos. Existing references to logos in html code have been edited accordingly -Removed reference to Font Awesome in all HTML pages as those will likely be unused and will increase load times. -Added main overflow-x: hidden and max-width: 100% styles to keep content from overflowing to the sides of the screen * Fixed Arrow Button * Removed Font Awesome Links --------- Co-authored-by: Quashnock <awq@uw.edu> * Created Our Story and Home pages (#45) Co-authored-by: Quashnock <awq@uw.edu> * Add base CSS files (#46) * Created Our Story and Home pages * Add CSS files to commit --------- Co-authored-by: Quashnock <awq@uw.edu> * Miro/2024 Events Page (#47) * Added Event Content and CSS * Added Slider, Array, and WIP Popup --------- Co-authored-by: Miro <miroslav.hr.slavchev@gmail.com> * Created Sponsor page, Instagram error state, and small bug fixes. (#48) Co-authored-by: Quashnock <awq@uw.edu> * Miro Events Page 9/13 update. (#49) * Added Event Content and CSS * Added Slider, Array, and WIP Popup * Completed Popup --------- Co-authored-by: Miro <miroslav.hr.slavchev@gmail.com> * Aaron/2024 sponsor page (#50) * Created Sponsor page, Instagram error state, and small bug fixes. * -Made Navbar fixed to follow user down the page when they scroll -Added content currently specified in the Figma -Attempted to fix undefined bug with mobile navbar --------- Co-authored-by: Quashnock <awq@uw.edu> * Update Footer.js * Robot page layout * Website Layout * Update Robots.html * Aaron/general cleanup (#51) * -Added final images and text * Fixed issues with homepage performance --------- Co-authored-by: Quashnock <awq@uw.edu> * Miro/2024 events page (#52) * Added Event Content and CSS * Added Slider, Array, and WIP Popup * Completed Popup * Completed Mobile Page * Fixing Bugs * Added Mobile Popup * -Fixed graphical bug with text going off the mobile pop-up at around 768px -Extrapolated creating elements to a function to make the syntax more compact and easier to read -Added alt tags and changed some colors to make the page more accessible --------- Co-authored-by: Miro <miroslav.hr.slavchev@gmail.com> Co-authored-by: Quashnock <awq@uw.edu> * Aaron/robots page (#53) * Created Robots page and added lazy-loading to images to improve performance * Including default.css into commit --------- Co-authored-by: Quashnock <awq@uw.edu> * Aaron/robots page (#54) * Created Robots page and added lazy-loading to images to improve performance * Including default.css into commit * Added aspect ratios to images to hopefully help them load better. Also added more resolutions to choose from in Join Us, I want to experiment with how this runs. --------- Co-authored-by: Quashnock <awq@uw.edu> * Aaron/robots page (#55) * Created Robots page and added lazy-loading to images to improve performance * Including default.css into commit * Added aspect ratios to images to hopefully help them load better. Also added more resolutions to choose from in Join Us, I want to experiment with how this runs. * Added more images for srcset to choose from to fuerther optimize performance. --------- Co-authored-by: Quashnock <awq@uw.edu> * Made bug fixes and removed unused images (#56) Co-authored-by: Quashnock <awq@uw.edu> * Aaron/final cleanup (#57) * Made bug fixes and removed unused images * Added width constraint for large screen sizes, updated text and content. * Made image sizing fix --------- Co-authored-by: Quashnock <awq@uw.edu> * Aaron/final cleanup (#58) * Made bug fixes and removed unused images * Added width constraint for large screen sizes, updated text and content. * Made image sizing fix * Fixed some sizing errors and replaced photo gallery text to be more fitting. --------- Co-authored-by: Quashnock <awq@uw.edu> * Aaron/final cleanup (#59) * Made bug fixes and removed unused images * Added width constraint for large screen sizes, updated text and content. * Made image sizing fix * Fixed some sizing errors and replaced photo gallery text to be more fitting. * Updated html file names, --------- Co-authored-by: Quashnock <awq@uw.edu> --------- Co-authored-by: Quashnock <awq@uw.edu> Co-authored-by: Miro <miroslav.hr.slavchev@gmail.com> Co-authored-by: Beastss10 <saharsh.inamdar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I specified the aspect ratio for all images to hopefully improve load times. I also added more resolutions to the images specifically in the Join Us page to give srcset more images to choose from. I am experimenting with the load times with this to see if it is necessary.