Connected deadline text to be dynamic google doc #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
adamseth2
commented
Aug 26, 2022
adamseth2
commented
- Connect deadline text to google doc ran by trickfirerobotics@gmail.com (0.5 sec to fetch text from API)
- deleted random console.log in footer
VladimirKupryukhin
approved these changes
Aug 26, 2022
Comment on lines
+5
to
+6
| const DELIMITER_END1 = '</span>'; | ||
| const DELIMITER_END2 = '"'; |
There was a problem hiding this comment.
Just to make things clear, the ending index will be at either </span> or at " on the Google Doc, whichever comes first?
Besides that, all is good.
There was a problem hiding this comment.
Yes because there is a weird thing that happens (i don't know why) but fetching the google doc has two potential results it can pull where one has after the text it ends with</span> or the other with ". That is why I added a couple of safety checks to make sure it doesn't mess up. I tried using google's own API to fetch the data making it more consistent and clean but it took 2 seconds to fetch so I opted to use this method instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.