Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EffectComposer does not correctly react to canvas resizing #29

Closed
Tinoooo opened this issue Jun 22, 2023 · 0 comments · Fixed by #30
Closed

EffectComposer does not correctly react to canvas resizing #29

Tinoooo opened this issue Jun 22, 2023 · 0 comments · Fixed by #30
Assignees
@Tinoooo
Labels
bug Something isn't working

Comments

@Tinoooo
Copy link
Contributor

Tinoooo commented Jun 22, 2023

Describe the bug
When resizing the viewport with an active effect composer, the scene gets distorted.

Reproduction
Steps

  1. open demo (in playground for example)
  2. change canvas size

Expected behavior
The scene should not become distorted

Screenshots
Kapture 2023-06-22 at 16 37 18
@Tinoooo Tinoooo self-assigned this Jun 22, 2023
@Tinoooo Tinoooo added the bug Something isn't working label Jun 22, 2023
Tinoooo pushed a commit that referenced this issue Jun 22, 2023
bugfix: fixed #29
015b55f
@Tinoooo Tinoooo linked a pull request Jun 22, 2023 that will close this issue
bugfix: 29 effectcomposer does not correctly react to canvas resizing #30
Merged
alvarosabu added a commit that referenced this issue Jun 26, 2023
@Tinoooo @alvarosabu
bugfix: 29 effectcomposer does not correctly react to canvas resizing (…
a0b177d 
…#30)

* feat: outline effect is now to a .vue file

* docs: docs for outline effect

* chore: replaced composer injection key by symbol

* bugfix: fixed #29

* chore: imported utility function from core

* chore: removed debug code

* chore: fixed effect by adding computeds

* chore: added more checks on condition

* feat: 23 refactor effects to vue files (#28)

* feat: outline effect is now to a .vue file

* docs: docs for outline effect

* chore: replaced composer injection key by symbol

---------

Co-authored-by: Tino Koch <tino.koch@xpoli.eu>

* fix: compute localCamera (#31)

---------

Co-authored-by: Tino Koch <tino.koch@xpoli.eu>
Co-authored-by: Alvaro Saburido <alvaro.saburido@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tinoooo Tinoooo

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: 29 effectcomposer does not correctly react to canvas resizing Tresjs/post-processing
1 participant
@Tinoooo