chore: reviews changes

Tresjs · Oct 5, 2023 · 535801d · 535801d
1 parent 3d790bc
commit 535801d
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 18 deletions.
diff --git a/docs/guide/abstractions/global-audio.md b/docs/guide/abstractions/global-audio.md
@@ -22,18 +22,18 @@ import { GlobalAudio } from '@tresjs/cientos'
 
 ## Props
 
-| Prop           | Description                                        | Default               |
-| :------------- | :------------------------------------------------- | --------------------- |
-| `src`          | Path to your audio file                            |                       |
-| `playElement`  | Id of the DOM element that trigger the play state  | `renderer.domElement` |
-| `pauseElement` | Id of the DOM element that trigger the pause state |                       |
-| `stopElement`  | Id of the DOM element that trigger the stop state  |                       |
-| `loop`         | If the audio must be replayed when ends            | `false`               |
-| `volume`       | Volume of the audio.                               | `0.5`                 |
-| `playbackRate` | PlaybackRate of the audio                          | `1`                   |
+| Prop           | Description                                         | Default               |
+| :------------- | :-------------------------------------------------- | --------------------- |
+| `src`          | Path to your audio file                             |                       |
+| `playElement`  | Id of the DOM element that triggers the play state  | `renderer.domElement` |
+| `pauseElement` | Id of the DOM element that triggers the pause state |                       |
+| `stopElement`  | Id of the DOM element that triggers the stop state  |                       |
+| `loop`         | If the audio must be replayed when ends             | `false`               |
+| `volume`       | Volume of the audio                                 | `0.5`                 |
+| `playbackRate` | PlaybackRate of the audio                           | `1`                   |
 
 ## Events
 
 | Event       | Description                                                       |
 | :---------- | :---------------------------------------------------------------- |
-| `isPlaying` | Dispatched when the Audio change its state (play, pause or stop). |
+| `isPlaying` | Dispatched when the Audio change its state (play, pause or stop)  |
diff --git a/playground/src/pages/abstractions/GlobalAudioDemo.vue b/playground/src/pages/abstractions/GlobalAudioDemo.vue
@@ -39,9 +39,9 @@ const options = useControls({
     />
     <GlobalAudio
       :src="exampleAudio"
-      :volume="options.volume.value.volume"
+      :volume="0.5"
       :loop="false"
-      :playback-rate="options.playbackRate.value.playbackRate"
+      :playback-rate="1"
       play-element="playBtn"
       pause-element="pauseBtn"
       stop-element="stopBtn"

diff --git a/src/core/abstractions/GlobalAudio.ts b/src/core/abstractions/GlobalAudio.ts
@@ -92,31 +92,31 @@ export const GlobalAudio = defineComponent<AudioProps>({
       }
     })
 
-    watch(() => [props.playbackRate], () => sound.setPlaybackRate( props.playbackRate || 1 ), { immediate: true })
-    watch(() => [props.volume], () => sound.setVolume( props.volume || 0.5 ), { immediate: true })
-    watch(() => [props.loop], () => sound.setLoop( props.loop || false ), { immediate: true })
+    watch(() => [props.playbackRate], () => sound.setPlaybackRate( props.playbackRate ?? 1 ), { immediate: true })
+    watch(() => [props.volume], () => sound.setVolume( props.volume ?? 0.5 ), { immediate: true })
+    watch(() => [props.loop], () => sound.setLoop( props.loop ?? false ), { immediate: true })
     watch(() => [props.src], async () => {
       const buffer = await audioLoader.loadAsync( props.src)
       sound.setBuffer( buffer )
 
     }, { immediate: true })
 
-    const selector = document.getElementById(props.playElement || '')
+    const selector = document.getElementById(props.playElement ?? '')
     const btnPlay = selector ? selector : renderer.value.domElement
     useEventListener(btnPlay, 'click', () => {
       sound.play()
       emit('isPlaying', sound.isPlaying)
     })
 
-    const btnPause = document.getElementById(props.pauseElement || '')
+    const btnPause = document.getElementById(props.pauseElement ?? '')
     if (btnPause) {
       useEventListener(btnPause, 'click', () => {
         sound.pause()
         emit('isPlaying', sound.isPlaying)
       })
     }
 
-    const btnStop = document.getElementById(props.stopElement || '')
+    const btnStop = document.getElementById(props.stopElement ?? '')
     if (btnStop) {
       useEventListener(btnStop, 'click', () => {
         sound.stop()