Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix carousel click problem #99

Merged
merged 1 commit into from
Feb 8, 2023
Merged

fix: fix carousel click problem #99

merged 1 commit into from
Feb 8, 2023

Conversation

saglamburcu
Copy link
Contributor

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
    diff --git a/.github/workflows/PULL_REQUEST_TEMPLATE.md b/.github/workflows/PULL_REQUEST_TEMPLATE.md

@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Base: 87.44% // Head: 89.43% // Increases project coverage by +1.99% 🎉

Coverage data is based on head (26de6ed) compared to base (237ba32).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   87.44%   89.43%   +1.99%     
==========================================
  Files          10       11       +1     
  Lines         422      426       +4     
  Branches      110      115       +5     
==========================================
+ Hits          369      381      +12     
+ Misses         53       45       -8     
Flag Coverage Δ
unittests 89.43% <100.00%> (+1.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/components/scrolling-carousel/defaultProps.ts 100.00% <100.00%> (ø)
src/components/scrolling-carousel/index.tsx 65.00% <100.00%> (+11.75%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aydinkn aydinkn merged commit 16e77ad into master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants