feat: add hide-arrows property #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minel
previously approved these changes
Apr 19, 2022
hasantezcan
force-pushed
the
feature/hideArrows
branch
from
04dc9a4 to
cab3351
Compare
hasantezcan
changed the title
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 87.04% 87.13% +0.09%
==========================================
Files 10 10
Lines 409 412 +3
Branches 106 108 +2
==========================================
+ Hits 356 359 +3
Misses 53 53
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
minel
previously approved these changes
Apr 19, 2022
hasantezcan
force-pushed
the
feature/hideArrows
branch
from
cab3351 to
a20a2eb
Compare
minel
previously approved these changes
Apr 19, 2022
hasangenc0
reviewed
Apr 19, 2022
| @@ -20,4 +20,5 @@ export const defaultProps: Required<CarouselProps> = { | |||
| autoSwipe: null, | |||
| navigation: null, | |||
| triggerClickOn: Number.MIN_SAFE_INTEGER, | |||
| hideArrows: false, | |||
There was a problem hiding this comment.
can you add it to docs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add hideArrows property to hide the left and right arrows.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).diff --git a/.github/workflows/PULL_REQUEST_TEMPLATE.md b/.github/workflows/PULL_REQUEST_TEMPLATE.md